Cleanup #116
Closed
Cleanup #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Jan 30, 2024
fingolfin
reviewed
Jan 30, 2024
| check=True, capture_output=True, text=True) | ||
| commit_date = subprocess.run( | ||
| ["git", "show", "-s", "--format=%as"], check=True, capture_output=True, text=True | ||
| ) |
There was a problem hiding this comment.
I don't mind much, but personally I find the new version harder to read than the old :-)
fingolfin
reviewed
Jan 30, 2024
fingolfin
reviewed
Jan 30, 2024
fingolfin
reviewed
Jan 30, 2024
fingolfin
reviewed
Jan 30, 2024
fingolfin
reviewed
Jan 30, 2024
| res = subprocess.run(["git", "diff-index", "--quiet", "HEAD", "--"]) | ||
| res = subprocess.run( | ||
| ["git", "diff-index", "--quiet", "HEAD", "--"], check=False | ||
| ) |
There was a problem hiding this comment.
What are you using to format the code? I just tried black and it doesn't touch is_git_clean for me
There was a problem hiding this comment.
I used black, sorry, I didn't really mean to format everything again. Note that here I also added check=False, which might make the difference.
* dev/releases/utils.py: move GitHub specific code to new file so that one can use the utils code without having the "github" python package installed. * Rename release_notes.readme.md -> README.release_notes.md * use `from utils import error, notice` * New script for generating release notes * Tweak dev/releases/create_stable_branch.py
The 'tee' and subshell combo ate the exit code. Also get rid of the 'dev/log' subdirectory.
... so that one can use the utils code without having the "github" python package installed.
james-d-mitchell
force-pushed
the
release-script
branch
from
1b57e75
to
96e0ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanups, there's one fixme, which is that in the current line
dev/releases/update_website.py:200:
there's no function named
extract_tarballin any of these scripts, so this line would fail if executed. I haven't tested these changes at all.